feat(notification): wire NotificationWithBackoff/RetryUntil to real queue retry by codedsultan · Pull Request #1528 · goravel/framework

codedsultan · 2026-07-31T18:23:05Z

Summary

Wires NotificationWithBackoff/RetryUntil to real queue retry behavior, using Goravel's documented optional queue.Job interface:

ShouldRetry(err error, attempt int) (retryable bool, delay time.Duration)

Confirmed against the documented job retry contract: https://www.goravel.dev/digging-deeper/queues.html#job-retry

Design

Backoff()/RetryUntil() are evaluated once, eagerly, in Manager.dispatchQueued — while the live notification still exists — and carried through the queue boundary as two new dispatchItem fields.
DispatchJob wraps a Deliver() failure in a small deliveryError type so ShouldRetry (called by the worker with only (err, attempt), no access to decoded job state) can recover them via errors.As.
DispatchJob itself stays fully stateless — no per-execution fields, since it's registered once and potentially shared across concurrent worker goroutines.
Without RetryUntil set, NotificationWithBackoff alone would retry indefinitely. Adds DefaultMaxRetryAttempts (exported var, default 10), applied only when RetryUntil isn't set — RetryUntil already provides its own bound and takes precedence when both are present.

Known limitation

Supports a single fixed backoff per notification+channel, not a growing per-attempt schedule — there's no live notification left to call a second time for a bigger number by retry time.

codecov · 2026-07-31T18:26:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.83%. Comparing base (cf1480b) to head (dd66aed).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
+ Coverage   69.80%   69.83%   +0.03%     
==========================================
  Files         409      409              
  Lines       31388    31428      +40     
==========================================
+ Hits        21909    21949      +40     
  Misses       8445     8445              
  Partials     1034     1034

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ueue retry Uses Goravel's documented optional queue.Job interface — ShouldRetry(err error, attempt int) (retryable bool, delay time.Duration) confirmed at https://www.goravel.dev/digging-deeper/queues.html#job-retry. Backoff()/RetryUntil() are evaluated once, eagerly, in Manager.dispatchQueued — while the live notification still exists — and carried through the queue boundary as two new dispatchItem fields. DispatchJob wraps a Deliver() failure in a small deliveryError type so ShouldRetry (called by the worker with only (err, attempt), no access to decoded job state) can recover them via errors.As. DispatchJob itself stays fully stateless — no per-execution fields, since it's registered once and potentially shared across concurrent worker goroutines. Without RetryUntil set, NotificationWithBackoff alone would retry indefinitely, since ShouldRetry had no other bound to check. Adds DefaultMaxRetryAttempts (exported var, default 10), applied only when RetryUntil isn't set — RetryUntil already provides its own bound and takes precedence when both are present. Known limitation: supports a single fixed backoff per notification+channel, not a growing per-attempt schedule — there's no live notification left to call a second time for a bigger number by retry time.

hwbrzzl · 2026-08-01T09:11:26Z

FYI, please add the Ready Review tag once it's ready.

codedsultan · 2026-08-02T07:36:25Z

FYI, please add the Ready Review tag once it's ready.

Ready Review. I cant find the tag is it a slash command ?

hwbrzzl · 2026-08-02T08:59:14Z

FYI, please add the Ready Review tag once it's ready.

Ready Review. I cant find the tag is it a slash command ?

Here

codedsultan · 2026-08-02T09:14:17Z

the setting icon doesn't appear for me in the label section

hwbrzzl · 2026-08-02T09:16:25Z

The setting icon? Could you paste a screenshot?

goravel-coder · 2026-08-02T09:43:46Z

PR #1528 wires NotificationWithBackoff as a fixed scalar (Backoff(channel string) int), but PR #1529 (queued broadcast retry) — which is consistent with Laravel — uses a per-attempt schedule: BroadcastBackoff() []time.Duration, last value repeats (BroadcastJob.ShouldRetry indexes min(attempt-1, len(backoff)-1)).

Laravel resolves backoff the same way (Worker::calculateBackoff: $backoff[$job->attempts() - 1] ?? last($backoff) — seconds, scalar or list).

Suggestion: keep #1528 consistent with #1529 — change Backoff(channel string) to return []time.Duration (per-attempt, last repeats) and index it in DispatchJob.ShouldRetry like BroadcastJob. This also removes the "single fixed backoff" limitation noted in this PR.

codedsultan · 2026-08-02T17:38:06Z

\

The setting icon? Could you paste a screenshot?

codedsultan · 2026-08-02T17:43:14Z

PR #1528 wires NotificationWithBackoff as a fixed scalar (Backoff(channel string) int), but PR #1529 (queued broadcast retry) — which is consistent with Laravel — uses a per-attempt schedule: BroadcastBackoff() []time.Duration, last value repeats (BroadcastJob.ShouldRetry indexes min(attempt-1, len(backoff)-1)).

Laravel resolves backoff the same way (Worker::calculateBackoff: $backoff[$job->attempts() - 1] ?? last($backoff) — seconds, scalar or list).

Suggestion: keep #1528 consistent with #1529 — change Backoff(channel string) to return []time.Duration (per-attempt, last repeats) and index it in DispatchJob.ShouldRetry like BroadcastJob. This also removes the "single fixed backoff" limitation noted in this PR.

Ok , i think i should wait for PR #1529 to be merged

hwbrzzl · 2026-08-03T01:43:38Z

The setting icon? Could you paste a screenshot?

Okay, sorry, I had a mistake.

hwbrzzl · 2026-08-03T07:22:19Z

@codedsultan #1529 has been merged

hwbrzzl · 2026-08-03T07:54:36Z

Given the broadcasting feature implements the Tries and Backoff functions, I think we can implement them in Notification as well. The RetryUntil function can be implemented when it's needed. @codedsultan What do you think about this, please?

codedsultan · 2026-08-04T04:26:01Z

Given the broadcasting feature implements the Tries and Backoff functions, I think we can implement them in Notification as well. The RetryUntil function can be implemented when it's needed. @codedsultan What do you think about this, please?

I will get back to you on this.

…ion-backoff-retry

codedsultan · 2026-08-09T19:14:52Z

Given the broadcasting feature implements the Tries and Backoff functions, I think we can implement them in Notification as well. The RetryUntil function can be implemented when it's needed. @codedsultan What do you think about this, please?

Notification now uses the same Tries/Backoff design as broadcasting: NotificationWithTries.Tries(channel string) int and NotificationWithBackoff.Backoff(channel string) []time.Duration, captured eagerly at dispatch and indexed in DispatchJob.ShouldRetry the same way BroadcastJob does (mutex-guarded item, last backoff value repeats)

codedsultan requested a review from a team as a code owner July 31, 2026 18:23

codedsultan force-pushed the feature/notification-backoff-retry branch from ff25d66 to a942be4 Compare July 31, 2026 18:34

codedsultan force-pushed the feature/notification-backoff-retry branch from a942be4 to dd9df8a Compare July 31, 2026 18:38

codedsultan added 4 commits August 9, 2026 12:49

wip: align notification backoff/retry with broadcasting pattern

aeadda8

Merge remote-tracking branch 'upstream/master' into feature/notificat…

a189387

…ion-backoff-retry

fix(notification): apply Tries/Backoff alignment with broadcasting

a883da5

build(mocks): update generated mocks for notification service

dd66aed

Uh oh!

Conversation

codedsultan commented Jul 31, 2026

Summary

Design

Known limitation

Uh oh!

codecov Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hwbrzzl commented Aug 1, 2026

Uh oh!

codedsultan commented Aug 2, 2026

Uh oh!

hwbrzzl commented Aug 2, 2026

Uh oh!

codedsultan commented Aug 2, 2026

Uh oh!

hwbrzzl commented Aug 2, 2026

Uh oh!

goravel-coder commented Aug 2, 2026

Uh oh!

codedsultan commented Aug 2, 2026

Uh oh!

codedsultan commented Aug 2, 2026

Uh oh!

hwbrzzl commented Aug 3, 2026

Uh oh!

hwbrzzl commented Aug 3, 2026

Uh oh!

hwbrzzl commented Aug 3, 2026

Uh oh!

codedsultan commented Aug 4, 2026

Uh oh!

codedsultan commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jul 31, 2026 •

edited

Loading

codedsultan commented Aug 9, 2026 •

edited

Loading